agatha/rhrtools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Missing patches #2

New Issue
Closed
opened 2025-07-26 13:26:05 +00:00 by agatha · 1 comment
agatha commented 2025-07-26 13:26:05 +00:00
Owner
Copy Link

After checking the number of patched ROMs, I find the last filename to be Week348.smc so I would expect 348 ROMs in the directory, but ls -l patched/ | wc -l returns 344, which is 343 ROMs. Something is off a little bit somewhere.

(venv) user@computer:~/storage/games/rhr/scraper (master)$ ls -l patched/ | tail
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week339.smc
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week340.smc
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week341.smc
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week342.smc
-rw-rw-r-- 1 user user 2097152 Jul 25 14:44 Week343.smc
-rw-rw-r-- 1 user user 2097152 Jul 25 14:44 Week344.smc
-rw-rw-r-- 1 user user 2097152 Jul 25 14:44 Week345.smc
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week346.smc
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week347.smc
-rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week348.smc
(venv) user@computer:~/storage/games/rhr/scraper (master)$ ls -l patched | wc -l
344
After checking the number of patched ROMs, I find the last filename to be `Week348.smc` so I would expect 348 ROMs in the directory, but `ls -l patched/ | wc -l` returns 344, which is 343 ROMs. Something is off a little bit somewhere. ``` (venv) user@computer:~/storage/games/rhr/scraper (master)$ ls -l patched/ | tail -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week339.smc -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week340.smc -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week341.smc -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week342.smc -rw-rw-r-- 1 user user 2097152 Jul 25 14:44 Week343.smc -rw-rw-r-- 1 user user 2097152 Jul 25 14:44 Week344.smc -rw-rw-r-- 1 user user 2097152 Jul 25 14:44 Week345.smc -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week346.smc -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week347.smc -rw-rw-r-- 1 user user 4194304 Jul 25 14:44 Week348.smc (venv) user@computer:~/storage/games/rhr/scraper (master)$ ls -l patched | wc -l 344 ```
agatha commented 2025-07-26 16:26:10 +00:00
Author
Owner
Copy Link

Looks like it's a false positive. I didn't account for the fact that some weeks may be skipped for whatever reason. Patched ROM count matches up with the number of patches:

(venv) user@computer:~/storage/games/rhr/scraper (master)$ find ./patches -name "*.bps" | wc -l
345
(venv) user@computer:~/storage/games/rhr/scraper (master)$ find ./patched -name "*.smc" | wc -l
345
Looks like it's a false positive. I didn't account for the fact that some weeks may be skipped for whatever reason. Patched ROM count matches up with the number of patches: ``` (venv) user@computer:~/storage/games/rhr/scraper (master)$ find ./patches -name "*.bps" | wc -l 345 (venv) user@computer:~/storage/games/rhr/scraper (master)$ find ./patched -name "*.smc" | wc -l 345 ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agatha
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: agatha/rhrtools#2
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?